refactor: 🥅 Change all error handling to use errno, add int32_t return codes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SizzinSeal
requested changes
Jan 2, 2025
SizzinSeal
requested changes
Jan 6, 2025
SizzinSeal
requested changes
Jan 10, 2025
There was a problem hiding this comment.
-
intshould be used instead ofuint32.
PROS, and the other lemlib projects, return the maximum value of a 32-bit signed integer on failure, so this should do the same. -
possible errno values and their meanings should be documented in the function doxygen documentation. See LemLib/hardware documentation
SizzinSeal
requested changes
Jan 22, 2025
include/gamepad/button.hpp
Outdated
| @@ -84,7 +84,7 @@ class Button { | |||
| * gamepad::master.Up.onPress("upPress1", []() { std::cout << "I was pressed!" << std::endl; }); | |||
| * @endcode | |||
| */ | |||
| bool onPress(std::string listenerName, std::function<void(void)> func) const; | |||
| uint32_t onPress(std::string listenerName, std::function<void(void)> func) const; | |||
There was a problem hiding this comment.
the functions return INT_MAX when errno is set, which is the maximum value of an int32_t. Consider changing them to int32_t for clarity, but this is not a requirement
Suggested change
| uint32_t onPress(std::string listenerName, std::function<void(void)> func) const; | |
| int32_t onPress(std::string listenerName, std::function<void(void)> func) const; |
include/gamepad/event_handler.hpp
Outdated
| std::lock_guard lock(m_mutex); | ||
| if (std::find(m_keys.begin(), m_keys.end(), key) != m_keys.end()) return false; | ||
| if (std::find(m_keys.begin(), m_keys.end(), key) != m_keys.end()) return UINT32_MAX; |
There was a problem hiding this comment.
Functions should return INT32_MAX when errno is set, so it does not differ from PROS and other LemLib projects
Suggested change
| if (std::find(m_keys.begin(), m_keys.end(), key) != m_keys.end()) return UINT32_MAX; | |
| if (std::find(m_keys.begin(), m_keys.end(), key) != m_keys.end()) return INT32_MAX; |
ion098
changed the title
SizzinSeal
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download the template for this pull request:
Note
This is auto generated from
Add Template to Pull Request