on_choice trigger and some in-place remodelling.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgatZan
commented
Oct 20, 2024
| @@ -1,14 +1,15 @@ | |||
| local M = {} | |||
|
|
|||
| ---@enum Scratch.Trigger | |||
There was a problem hiding this comment.
AgatZan
commented
Oct 21, 2024
lua/scratch/config.lua
Outdated
Comment on lines
62
to
68
| local co = coroutine.running() | ||
| local confirmer = function(input) | ||
| coroutine.resume(co, input) | ||
| end | ||
| confirmer = vim.schedule_wrap(confirmer) | ||
| vim.ui.input({ prompt = "Input filetype: " }, confirmer) | ||
| return coroutine.yield() |
There was a problem hiding this comment.
Another approach to realizing that use case is to use vim.wait(1). I guess it should work, my suggestion depends on an async cycle, but I haven't tested it so I really don't know how to make it better.
And remove coroutine.wrap() from it
There was a problem hiding this comment.
I tried vim.wait like this:
local some
vim.ui.input(...)
vim.wait(1, function() return vim.g.__var_wait end)
return someAnd it doesn't work at all, so maybe it should be implemented differently.
AgatZan
commented
Oct 22, 2024
lua/scratch/api.lua
Outdated
| @@ -8,6 +8,7 @@ local MANUAL_INPUT_OPTION = "MANUAL_INPUT" | |||
| ---@class Scratch.ActionOpts | |||
| ---@field window_cmd? Scratch.WindowCmd | |||
| ---@field content? string[] content will be put into the scratch file | |||
| ---@field hooks? {[string]: Scratch.Hooks, [Scratch.Trigger]:Scratch.Hook} | |||
There was a problem hiding this comment.
[string]: Scratch.Hooks it is because after choosing, you need to call correctly. I think another approach is table<Scratch.Trigger, table<string, Scratch.Hook>| Scratch.Hook>
Each of the ideas is disgusting in its own way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept #48