-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro config routes & UI #339
Conversation
✅ Deploy Preview for lodestone-dashboard canceled.
|
✅ Deploy Preview for lodestone-storybook canceled.
|
…s a mismatch of config names
…estone into macro_config_frontend
Macro config frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dropdown is not scrollable
Another problem: the frontend crashes when trying to edit the config or the following:
class LodestoneConfig {
// the id of the instance
id: number = 1;
/**
* the location of the backups
*/
backupType: 'local' | 'online' | 'disabled' | 'test1' | 123123 = 'local';
allowDuplicates: boolean = true;
}

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class LodestoneConfig {
// the id of the instance
id: number = 1;
/**
* the location of the backups
*/
backupType: 'local' | 'test' = random junk;
allowDuplicates: boolean = true;
}
Causes backend to panic when constructing a SettingManfiest
, which drops the request from the frontend and causes a network error:

…alue is entered for a enum macro config
Description
Type of change
Note: make sure your files are formatted with rust-analyzer