Add periodic in-memory store pruner #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luzifer
requested changes
Oct 26, 2024
Luzifer
approved these changes
Oct 27, 2024
Luzifer
changed the title
|
Thanks for adding the cleanup! Though the in-mem store should only be used for testing, it's good to have it properly managed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement better memory management for the in memory store.
Currently secrets only get deleted once they are read while still valid or attempted to be read once expired. This change implements a go routine that periodically iterates over secrets held in memory and if the secret is expired, deletes it. This will lead to better memory efficiency as expired secrets without any desire to be read won't linger in memory indefinitely.