Skip to content
This repository has been archived by the owner on Mar 10, 2019. It is now read-only.

Commit

Permalink
remove visualizer plugin
Browse files Browse the repository at this point in the history
The current implementation is a dead end and I don't have the time
or interest to rewrite it again.
  • Loading branch information
Jonathan Matthew committed Jul 3, 2017
1 parent 80f08e8 commit 6fcb68f
Show file tree
Hide file tree
Showing 23 changed files with 0 additions and 2,102 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ metadata/test-metadata
plugins/audiocd/sj-metadata-marshal.c
plugins/audiocd/sj-metadata-marshal.h
plugins/daap/rb-daap-glue.h
plugins/visualizer/rb-visualizer-glue.h

#
sample-plugins/sample-vala/rb-sample-vala-plugin.c
Expand Down
2 changes: 0 additions & 2 deletions INSTALL.quick
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Rhythmbox can also make use of the following packages:
- libdmapsharing 2.9.11 or newer
- libmtp 0.3.0 or newer
- grilo 0.3.0 or newer
- clutter 1.8, clutter-gst 1.4, clutter-gtk 1.0 and mx 1.0.1 or newer
for music visualization


Simple install procedure
Expand Down
35 changes: 0 additions & 35 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,6 @@ AC_DEFINE(GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_2_38, [minimum glib version])
AC_DEFINE(GLIB_VERSION_MAX_ALLOWED, GLIB_VERSION_2_38, [maximum glib version])
AC_DEFINE(GDK_VERSION_MIN_REQUIRED, GDK_VERSION_3_16, [minimum gdk version])
AC_DEFINE(GDK_VERSION_MAX_ALLOWED, GDK_VERSION_3_16, [maximum gdk version])
AC_DEFINE(CLUTTER_VERSION_MIN_REQUIRED, CLUTTER_VERSION_1_8, [minimum clutter version])
AC_DEFINE(CLUTTER_VERSION_MAX_ALLOWED, CLUTTER_VERSION_1_8, [maximum clutter version])

dnl Check for -fno-strict-aliasing
FLAGS="-fno-strict-aliasing"
Expand Down Expand Up @@ -669,32 +667,6 @@ AM_CONDITIONAL(USE_LIBDMAPSHARING, test x"$have_libdmapsharing" = "xyes")
AC_SUBST(DMAPSHARING_CFLAGS)
AC_SUBST(DMAPSHARING_LIBS)

dnl ================================================================
dnl clutter for visualizer plugin
dnl ================================================================
AC_ARG_ENABLE(visualizer,
AC_HELP_STRING([--disable-visualizer],
[Disable visualizer plugin support]),,
enable_visualizer=auto)
if test "x$enable_visualizer" != "xno"; then
PKG_CHECK_MODULES(CLUTTER,
clutter-1.0 >= 1.8 \
clutter-x11-1.0 >= 1.8 \
clutter-gst-2.0 \
clutter-gtk-1.0 >= 1.0 \
mx-1.0 >= 1.0.1,
have_clutter=yes,
have_clutter=no)
if test "x$have_clutter" = "xno" -a "x$enable_visualizer" = "xyes"; then
AC_MSG_ERROR([Visualizer support explicitly requested, but clutter couldn't be found])
fi
fi

AM_CONDITIONAL(USE_CLUTTER, test x"$have_clutter" = "xyes")

AC_SUBST(CLUTTER_CFLAGS)
AC_SUBST(CLUTTER_LIBS)

dnl ================================================================
dnl grilo plugin
dnl ================================================================
Expand Down Expand Up @@ -783,7 +755,6 @@ plugins/mpris/Makefile
plugins/dbus-media-server/Makefile
plugins/rbzeitgeist/Makefile
plugins/notification/Makefile
plugins/visualizer/Makefile
plugins/grilo/Makefile
plugins/soundcloud/Makefile
plugins/webremote/Makefile
Expand Down Expand Up @@ -881,10 +852,4 @@ else
AC_MSG_NOTICE([ iTunes detection browser plugin (for podcasts) disabled])
fi

if test "x$have_clutter" = xyes; then
AC_MSG_NOTICE([** Visualizer plugin enabled])
else
AC_MSG_NOTICE([ Visualizer plugin disabled])
fi

AC_MSG_NOTICE([End options])
18 changes: 0 additions & 18 deletions data/org.gnome.rhythmbox.gschema.xml
Original file line number Diff line number Diff line change
Expand Up @@ -415,24 +415,6 @@
</key>
</schema>

<enum id="org.gnome.rhythmbox.plugins.visualizer.quality">
<value nick="low" value="0"/>
<value nick="medium" value="1"/>
<value nick="high" value="2"/>
</enum>
<schema id="org.gnome.rhythmbox.plugins.visualizer" path="/org/gnome/rhythmbox/plugins/visualizer/">
<key name="vis-plugin" type="s">
<default>'goom'</default>
<summary>GStreamer element to use for visual effects</summary>
<description>The name of the GStreamer element to use for visual effects.</description>
</key>
<key name="vis-quality" enum="org.gnome.rhythmbox.plugins.visualizer.quality">
<default>'medium'</default>
<summary>The frame rate and size to use for visual effects</summary>
<description>The frame rate and size to use for visual effects</description>
</key>
</schema>

<schema id="org.gnome.rhythmbox.plugins.grilo" path="/org/gnome/rhythmbox/plugins/grilo/">
<child name="source" schema="org.gnome.rhythmbox.source"/>
</schema>
Expand Down
3 changes: 0 additions & 3 deletions doc/reference/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ IGNORE_HFILES= \
rb-rhythmdb-dmap-db-adapter.h \
rb-rhythmdb-query-model-dmap-db-adapter.h \
rb-station-properties-dialog.h \
rb-visualizer-fullscreen.h \
rb-visualizer-menu.h \
rb-visualizer-page.h \
sj-metadata-marshal.h \
\
test-utils.h
Expand Down
4 changes: 0 additions & 4 deletions plugins/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ if ENABLE_FM_RADIO
SUBDIRS += fmradio
endif

if USE_CLUTTER
SUBDIRS += visualizer
endif

if USE_NOTIFY
SUBDIRS += notification
endif
Expand Down
79 changes: 0 additions & 79 deletions plugins/visualizer/Makefile.am

This file was deleted.

Binary file removed plugins/visualizer/button-active.png
Binary file not shown.
Binary file removed plugins/visualizer/button-disabled.png
Binary file not shown.
Binary file removed plugins/visualizer/button-focus.png
Binary file not shown.
Binary file removed plugins/visualizer/button-hover.png
Binary file not shown.
Binary file removed plugins/visualizer/button.png
Binary file not shown.
Loading

0 comments on commit 6fcb68f

Please sign in to comment.