Fix: Specify MHKiT-Python version for tests and users #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`macos-14` and `macos-latest` use arm builds of MacOS that are not compatible with matlab-actions/setup-matlab@v2.
This code compatibility testing is done in MATLAB and should be the same across platforms. Running this on all platforms uses a lot of jobs and slows down the other tests.
rpauly18
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.8.0 release of MHKiT-Python introduces incompatibilities in MHKiT-MATLAB. Specific failing tests are detailed in #130.
This PR specifies the MHKiT-Python version in the documentation and tests. This is a temporary solution until we reach parity with MHKiT Python. At that time it will be useful to test against the
developbranch, which should help us catch these types of bugs earlier in the development cycle.