Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make save dir not having end-separator #71

Closed
wants to merge 1 commit into from

Conversation

gabyx
Copy link

@gabyx gabyx commented Nov 24, 2024

  • the save dir should not have a end separator, IMO.
  • corrected the readme too.

@gabyx gabyx force-pushed the fix/make-save-dir-correct branch from 29951a4 to 2d64d34 Compare November 24, 2024 08:50
@gabyx gabyx changed the title fix: make save dir not having separator fix: make save dir not having end-separator Nov 24, 2024
Copy link
Owner

@MLFlexer MLFlexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

  1. Have you tested this locally?

  2. Out of curiosity is it convention or useful in some way to not have the end-seperator?
    I am myself not aware of any reasons other than stylistic reasons, but maybe there is more to it?
    Either way, I would not mind merging this as I don't really have an opinion for when to have or not have the endning seperator in directories

@gabyx
Copy link
Author

gabyx commented Nov 27, 2024

Its a convention.
And just weird. The PR does not work currently as there are more cases where you do some regex/sub or prefix removal which now does not work anymore.

@gabyx
Copy link
Author

gabyx commented Nov 27, 2024

You can have the end separator internally, but I would not suggest, and make the API that it is agnostic to end separator ...

@MLFlexer
Copy link
Owner

Closing as it is not fixed, but opened #76 to eventually fix

@MLFlexer MLFlexer closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants