fix: remove non-ros dependency #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about adding include(FetchContent)
if (NOT TARGET qualisys_cpp_sdk)
message(STATUS "${PROJECT_NAME}: `qualisys_cpp_sdk` targets not found. Attempting to fetch contents...")
FetchContent_Declare(
qualisys_cpp_sdk
GIT_REPOSITORY https://github.com/qualisys/qualisys_cpp_sdk
GIT_TAG master
)
FetchContent_MakeAvailable(qualisys_cpp_sdk)
else()
message(STATUS "qualisys_cpp_sdk: `qualisys_cpp_sdk` targets found.")
endif()to the cmakelists.txt ? |
|
This works like that. Commit messages got a little messy though. If you find this approach good enough, I can clean up the commit messages and make another PR, or somehow update this one. |
|
LGTM, go ahead. Is the PR ready to merge? Thanks!! |
|
Nööö!!! 😆 There are too many weird commits in it. I will properly do it and create another pull request. I will turn this into a draft for now. |
|
Did you progress with this? |
|
Hi @incebellipipo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #5
It is not ready for merge yet; we can discuss the ways to handle SDK dependency before it.