Show user and pack durations as minutes if less than an hour #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'0:03 hours' isn't very useful, better to show '3:45 minutes'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #1818
Description
'0:03 hours' isn't very useful, better to show '3:45 minutes'
The code for computing/selecting hours vs minutes is duplicated in two places, for now I'm not worried about this but we could combine it in a helper if needed. The
|duration_hourstemplatetag is still used elsewhere, so don't remove it.I updated the test settings to disable the cache, so that I could read values for the test multiple times. I think it generally makes sense to disable the cache during tests? although some tests are now failing.
If we want to keep it then I can work around it for just this test.