Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i added one example because during the writing another part of the do… #3683

Conversation

SirJamesClarkMaxwell
Copy link
Contributor

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Added buff example for Arrow class
More code examples are almost always a good idea, especially if something is slightly silly in docs and could be potentially accessible to miss in roll docs.
I hope that this is correct syntax of the example code

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

…cs, i had a struggle with this buff thing, and imo it would be perfect if this type of "bugs" have a representation in example docs code
@JasonGrace2282
Copy link
Member

I don't think this is a valuable addition to the library. A whole example just related to the buff parameter seems to me like a waste of rendering time with minimal benefit.

@SirJamesClarkMaxwell SirJamesClarkMaxwell deleted the buff_issue_in_arrow branch April 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants