MassBank record from MS-DIAL #266
Conversation
|
Hi @Bujee415 , |
|
Hi @meier-rene |
|
Hi Kozo, There was one minor issue with the github workflow not getting started automatically. I dont know why and I didnt investigate further. I could still trigger it manually. It didnt happen again with other PRs. From my point of view, this issue is solved. MSDIAL creates valid MassBank record format files. Anything else I should do with this PR? |
|
Hi René, thanks for your reply. |
|
If you are going to add more data than I would like to ask for a modification of your data processing settings. Unfortunately I can not advice on the best settings, because I rarely work on actual MS data and never use an instrument. I'm not an MS expert and the final decision about the data is in the hands of the contributor. I realized that there is a significant number of peaks with a very low intensity in this one dataset. In general we prefer data in centroid mode with some noise reduction and I would like to ask for some adjustments in your data preparation to have a lower number of peaks if it does not remove any features. But finally its your decision. |
|
Hi,
Just for reference: GitHub requires an explicit trigger for actions by first-time contributors (to avoid PRs mining Bitcoin). Subsequent PRs are checked automatically afterwards. Yours, |
|
@meier-rene Thanks. What we uploaded is from EAD-MS/MS, where very low peaks should have meaningful substructure information, frequently less than 5 ion counts. So we would like to upload them as is. |
|
Hi @meier-rene |
|
Hi all
Sorry for any confusion caused. What I have mentioned in our lab Slack is
only about priority, not about not depositing EAD spectra from our group to
MassBank. We have other priorities to address at the moment.
Thanks
Hiroshi
2024年12月29日(日) 22:04 Kozo Nishida ***@***.***>:
… Hi @meier-rene <https://github.com/meier-rene>
Could you ignore my comment in #266 (comment)
<#266 (comment)>
?
I’ve heard from @htsugawa <https://github.com/htsugawa> that @htsugawa
<https://github.com/htsugawa> is not planning to include any records
other than MSBNK-TUAT-MSDIAL24082900000039 in this PR.
For this PR, @htsugawa <https://github.com/htsugawa> just wants to check
if MSBNK-TUAT-MSDIAL24082900000039 passes the GitHub Actions validator.
Would it be possible for you to enable the trigger in Steffen's comment #266
(comment)
<#266 (comment)>
?
(I understand that we can’t activate the trigger on our end, and only you
can.)
—
Reply to this email directly, view it on GitHub
<#266 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGUDIK3GED2IZOO4HRVB2RT2H7XMHAVCNFSM6AAAAABNJYPEY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG4YTQNRSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi, I enabled the trigger on 16.12. and from then onwards all PRs in MassBank-data by github user @Bujee415 will be considered trusted and processed without further action from our side. |
|
Thank you very much Steffen sensei!!
Hiroshi
2024年12月30日(月) 2:09 Steffen Neumann ***@***.***>:
… Hi, I enabled the trigger on 16.12. and from then onwards all PRs in
MassBank-data by github user @Bujee415 <https://github.com/Bujee415> will
be considered trusted and processed without further action from our side.
Indeed, the checks passed, please see the "Checks (1)" tab on the PR page,
or go to
https://github.com/MassBank/MassBank-data/actions/runs/10610406333/job/29563688956
directly.
Unfortunately, GitHub keeps the detailed logs only for so long, so apart
from "This job succeeded" there is no additional information to see.
Yours, STeffen
—
Reply to this email directly, view it on GitHub
<#266 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGUDIK26NK5TVQHJ6SDIZFL2IAUFFAVCNFSM6AAAAABNJYPEY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG44DINZQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.