-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Site Layout Editor - Meeds-io/MIPs#175 #4404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-io/MIPs#175 (#4369) This change will add a specific class on Site Body when scrolled so that a specific class can be applied on Site content when scrolled such as an 'elevation' behavior.
…MEED-8281 - Meeds-io/MIPs#175 (#4385) This change will allow to centralize the system apps and divs to be served by `UIPortalApplication` rather than AddonContainers added inside the `sharedlayout.xml` and `portal.xml` of standalone sites.
MEED-8266 - Meeds-io/MIPs#175 (#4386) This change will adapt the Topbar Loading styling since it has been moved from Topbar Container definition to portal main page (UIPortalApplication).
(#4389) This change will remove the global 'exo-drawer' overlay management for sidebar to use an internal overlay or the default one to fix the z-index issue of global overlay component which hides all 'attached' drawers.
…eeds-io/MIPs#175 Prior to this change, the Topbar wasn't elevated when the site body is scrolled. This change add a new Class Helper in HTML Body in order to allow applying a CSS Class which elevates the Topbar once the page body is scrolled.
This change will allow to use a scrollbar inside a dedicated zont of the site instead of the whole page depending on OffsetTop of the scrollable element.
…s#175 This change will allow to make the ACL check on current site inside the application rather than add it inside the site layout definition in order to simplify the business logic of public site which will simply use 'Everyone' as application permissions value.
Meeds-io/MIPs#175 (#4392) Prior to this change, the Vertical Menu App wasn't using the default Applications style defined using Layout Editor. This change will ensure to be able to brand the menu using Layout Style. In addition, this will fix Notification Drawer Styling independently from Drawer Mounted PArent destination.
When decrementing, the value can be set greater to the max, thus a Math.min and Math.max has been added to ensure to not set value out of range.
This change will move the co-edition Reusable Component from Layout to allow use it in other editors such as notes and news which relies on Draft management.
This change will delete an extra margin added in `Page Not Found` UI due to a deprecated class used in parent node of portlet.
…DispatchedViewPortlet - Meeds-io/MIPs#175 This change will delete rendering of JSManager Tag when a single Portlet Application is requested to be displayed. This strategy isn't used anymore since the layout rendering is deferred and loaded using Ajax.
eeda288
to
3bd472d
Compare
AzmiTouil
approved these changes
Feb 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#175