-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various QuickLook fixes and enhancements of surface plot functionality. #1122
Conversation
Note: we currently look for variables with no cell_methods. This could become difficult if we want to compare time-meaned variables in the future. |
Update 11/02: All surface variables working, but need to update and tidy code and add new tests. |
surface_temperature has colourbar in degreeC and data in K. Need to change "surface_temperature": { into kelvin values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. There needs to be an additional test for regridding during the difference plot, and there are a few minor code suggestions.
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
Have added a test for regridding, not sure what to assert other than it didn't fail and successfully regridded, and thus returned a cube, so using type? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for test conditions.
Co-authored-by: James Frost <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Addresses #1062.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.