-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill out colorbar definitions for missing variables #1145
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like really good coverage for filling in the variables we had missed. The ranges look sensible, as do the colour maps for the variables.
However for the difference plots we should use a diverging colour map to show the direction and magnitude of the change, as these are designed to have a neutral point at 0, and even perceptual lightness either side.
"min": 0.0 | ||
}, | ||
"atmosphere_cloud_ice_content_difference": { | ||
"cmap": "Blues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the differences we probably want to stick with bwr
colour maps so you can see the difference. You could make a case for another diverging colour map, but I don't think Blues is suitable.
"min": 0.0 | ||
}, | ||
"toa_direct_shortwave_flux_difference": { | ||
"cmap": "viridis", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
@@ -531,7 +637,13 @@ | |||
"max": 0.01, | |||
"min": 0 | |||
}, | |||
"surface_microphysical_snowfall_rate_difference": { | |||
"cmap": "cool", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"min": 0 | ||
}, | ||
"surface_downwelling_shortwave_flux_in_air_difference": { | ||
"cmap": "Greys", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"min": 0 | ||
}, | ||
"surface_downwelling_longwave_flux_in_air_difference": { | ||
"cmap": "Greys_r", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"atmosphere_mass_content_of_water_vapor": { | ||
"cmap": "Blues", | ||
"max": 100, | ||
"min": 0 | ||
}, | ||
"atmosphere_mass_content_of_water_vapor_difference": { | ||
"cmap": "Blues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"min": 0.0 | ||
}, | ||
"atmosphere_mass_content_of_cloud_liquid_water_difference": { | ||
"cmap": "Blues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"atmosphere_mass_content_of_cloud_ice": { | ||
"cmap": "Blues", | ||
"max": 5, | ||
"min": 0.0 | ||
}, | ||
"atmosphere_mass_content_of_cloud_ice_difference": { | ||
"cmap": "Blues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"min": 0.0 | ||
}, | ||
"atmosphere_cloud_liquid_water_content_difference": { | ||
"cmap": "Blues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be diverging colourmap.
"max": 135.0, | ||
"min": -135.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This range seems rather large given the range for the variable is only -35 to 70.
more surface plot colorbar changes off ticket #1136
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.