Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out colorbar definitions for missing variables #1145

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

BernardClaxton
Copy link
Contributor

@BernardClaxton BernardClaxton commented Feb 14, 2025

more surface plot colorbar changes off ticket #1136

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@BernardClaxton BernardClaxton marked this pull request as ready for review February 14, 2025 16:59
Copy link
Contributor

Coverage

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like really good coverage for filling in the variables we had missed. The ranges look sensible, as do the colour maps for the variables.

However for the difference plots we should use a diverging colour map to show the direction and magnitude of the change, as these are designed to have a neutral point at 0, and even perceptual lightness either side.

"min": 0.0
},
"atmosphere_cloud_ice_content_difference": {
"cmap": "Blues",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the differences we probably want to stick with bwr colour maps so you can see the difference. You could make a case for another diverging colour map, but I don't think Blues is suitable.

"min": 0.0
},
"toa_direct_shortwave_flux_difference": {
"cmap": "viridis",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

@@ -531,7 +637,13 @@
"max": 0.01,
"min": 0
},
"surface_microphysical_snowfall_rate_difference": {
"cmap": "cool",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"min": 0
},
"surface_downwelling_shortwave_flux_in_air_difference": {
"cmap": "Greys",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"min": 0
},
"surface_downwelling_longwave_flux_in_air_difference": {
"cmap": "Greys_r",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"atmosphere_mass_content_of_water_vapor": {
"cmap": "Blues",
"max": 100,
"min": 0
},
"atmosphere_mass_content_of_water_vapor_difference": {
"cmap": "Blues",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"min": 0.0
},
"atmosphere_mass_content_of_cloud_liquid_water_difference": {
"cmap": "Blues",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"atmosphere_mass_content_of_cloud_ice": {
"cmap": "Blues",
"max": 5,
"min": 0.0
},
"atmosphere_mass_content_of_cloud_ice_difference": {
"cmap": "Blues",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

"min": 0.0
},
"atmosphere_cloud_liquid_water_content_difference": {
"cmap": "Blues",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be diverging colourmap.

Comment on lines +422 to +423
"max": 135.0,
"min": -135.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This range seems rather large given the range for the variable is only -35 to 70.

@jfrost-mo jfrost-mo changed the title amended fix for radar_reflectivity_at_1km_above_the_surface #1138 Fill out colorbar definitions for missing variables Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants