fix(Pagination) detect existence of question mark in URL in order to use correct parameter separator when adding parameters to the URL #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ajax URL I use to retrieve data has parameters:
index.php?param1=val1¶m2=val2....
so when the pagination code adds the "page" parameter with a hardcoded question mark it doesn't work correctly. I added an "if" to detect the existence of a question mark in order to set the correct parameter separator and it is working correctly in both case.