Ryan Horn Backend Task #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement the Exchange Rate Provider using the publicly available API of the Czech National Bank which I found online.
I have created a MVP that satisfies the requirements. I have tried to keep the solution as simple and concise as possible so it is easily maintainable. I have considered a few principles when developing this project such as SOLID and DRY both of which help keep the code high quality, maintainable and reusable.
I have added a Nunit test project which contains a suite of tests for the service and the provider. I have used private methods in the files to reduce the repeatition of code that comes from mocking up the httpClient.
I have also updated the project to .NET8 to keep the solution up to date with the industry. I have introduced file-scoped namespaces to reduce excess noise in files.