Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-5206 Add documentation fo RequestedRateCode property in reservations/getAll/2023-06-06 endpoint #728

Merged
merged 2 commits into from
Jan 30, 2025
Merged

CON-5206 Add documentation fo RequestedRateCode property in reservations/getAll/2023-06-06 endpoint #728

merged 2 commits into from
Jan 30, 2025

Conversation

ShadiWa
Copy link
Contributor

@ShadiWa ShadiWa commented Jan 24, 2025

Summary

Checklist

  • Documentation follows the Style Guide
  • JSON examples updated
  • Properties in JSON examples are in the same order as in property tables
  • Changelog dated the day when PR merged
  • Changelog accurately describes all changes
  • Changelog highlights the affected endpoints or operations
  • Changelog highlights any deprecations
  • All hyperlinks tested
  • Deprecation Table updated if any deprecations
  • SUMMARY.md updated if new pages added

@ShadiWa ShadiWa added Generator Pull requests related to reference documentation generator con.connectivity labels Jan 24, 2025
@ShadiWa ShadiWa self-assigned this Jan 24, 2025
@ShadiWa ShadiWa requested review from a team as code owners January 24, 2025 11:28
RobBeck1
RobBeck1 reviewed Jan 24, 2025
View reviewed changes
changelog/README.md Outdated Show resolved Hide resolved
RobBeck1
RobBeck1 requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@RobBeck1 RobBeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on line 3 of the changeLog. I think the structure of the file has changed recently 👍

@ShadiWa ShadiWa requested a review from RobBeck1 January 30, 2025 14:46
RobBeck1
RobBeck1 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@RobBeck1 RobBeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ShadiWa ShadiWa merged commit 2ee9600 into master Jan 30, 2025
2 checks passed
@ShadiWa ShadiWa deleted the CON-5206-Add-documentation-fo-RequestedRateCode-property-in-reservations/getAll/2023-06-06-endpoint branch January 30, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobBeck1 RobBeck1 RobBeck1 approved these changes

Assignees

@ShadiWa ShadiWa

Labels
con.connectivity Generator Pull requests related to reference documentation generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShadiWa @RobBeck1