Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolvers): add resolver types exports #36

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

smonist
Copy link
Contributor

@smonist smonist commented Aug 21, 2023

πŸ”— Linked issue

#35

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change makes the resolver package usable with "moduleResolution": "Bundler". The types of the packages are exported explicitly now.
Please note that this is a quick fix. To be really close to current TypeScript standards, .mts and .cjs files should be generated in addition to .d.ts files. Look here for further information.

πŸ“ Checklist

  • I have read the Contributing Guidelines.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Mini-ghost Mini-ghost merged commit a2e25a9 into Mini-ghost:main Aug 24, 2023
@YannicEl
Copy link

Thank you so much for this PR @smonist
Ran into the same issue yesterday
I'm glad it's fixed now. ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants