remove some redundant condition check for last snapshot #217
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
util/base58/base58check_test.go#L68
File is not `gofumpt`-ed (gofumpt)
|
|
lint:
util/base58/base58_test.go#L29
the line is 157 characters long, which exceeds the maximum of 120 characters. (lll)
|
|
lint:
util/base58/base58_test.go#L66
the line is 154 characters long, which exceeds the maximum of 120 characters. (lll)
|
|
lint:
util/base58/base58_test.go#L67
the line is 870 characters long, which exceeds the maximum of 120 characters. (lll)
|
|
lint:
util/base58/base58check_test.go#L28
the line is 167 characters long, which exceeds the maximum of 120 characters. (lll)
|
|
lint:
util/base58/base58check_test.go#L69
unnecessary trailing newline (whitespace)
|
|
lint:
util/base58/base58_test.go#L12
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58bench_test.go#L11
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58check_test.go#L10
import 'github.com/MixinNetwork/mixin/util/base58' is not allowed from list 'Main' (depguard)
|
|
lint:
util/base58/base58_test.go#L85
Duplicate words (failed) found (dupword)
|
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
p2p/peer.go#L113
receiver-naming: receiver name p should be consistent with previous receiver name me for Peer (revive)
|
|
lint:
p2p/peer.go#L384
receiver-naming: receiver name p should be consistent with previous receiver name me for Peer (revive)
|
|
lint:
p2p/util.go#L39
var-naming: struct field Id should be ID (revive)
|
|
lint:
p2p/sync.go#L87
var-naming: method parameter nodeId should be nodeID (revive)
|
|
lint:
p2p/handle.go#L60
var-naming: struct field PeerId should be PeerID (revive)
|
|
lint:
p2p/handle.go#L69
var-naming: interface method parameter relayerId should be relayerID (revive)
|
|
lint:
p2p/handle.go#L70
var-naming: interface method parameter recipientId should be recipientID (revive)
|
|
lint:
p2p/handle.go#L72
var-naming: interface method parameter peerId should be peerID (revive)
|
|
lint:
p2p/handle.go#L75
var-naming: interface method parameter nodeIdWithNetwork should be nodeIDWithNetwork (revive)
|