Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture buttons' behaviors #216

Closed
grahamas opened this issue Jan 8, 2018 · 8 comments · Fixed by #251
Closed

Capture buttons' behaviors #216

grahamas opened this issue Jan 8, 2018 · 8 comments · Fixed by #251
Assignees
Labels
bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@grahamas
Copy link

grahamas commented Jan 8, 2018

When you start a new capture, there is no way to back out without saving the capture. Pressing "< Capture" saves whatever is written (or not written) as if you had pressed "Done." On the other hand, as far as I can tell, "Done" doesn't do anything useful.

A more expected behavior would be for "< Capture" to discard the current capture and return to the Capture menu. I suspect that's too aggressive and might break usecases of established users, so a somewhat reasonable compromise would be for "< Capture" to discard the note if there is no text in the capture.

A more expected behavior for "Done" would be either (a) to save the capture and back out into the capture menu, or (b) to save the capture and start a new capture automatically. I would favor the latter for quick successive capture entries, but notice it would only work if the "< Capture" behavior is changed.

As it stands, the Autocapture mode makes the app somewhat unusable for anything but the case where you exclusively use the app for capturing. Personally, I would use the app 90% of the time for capturing, but whenever I want to view the TODO list I'd rather not go through the hassle of deleting the blank capture I created. (The "hassle" of three taps, I'll grant you, but in appland that's crazy).

@grahamas grahamas changed the title Blank captures Capture buttons' behaviors Jan 8, 2018
@DivineDominion
Copy link
Contributor

DivineDominion commented Feb 14, 2018

Unlike editing forms for submission, where discarding the data with a Cancel nav button makes sense, that would be weird for editing files.

I’d opt for

  • simply removing the Done button like other editors do when editing
  • add Cancel to the right (! not where the non-destructive back button is usually) when adding a new capture

@grahamas
Copy link
Author

That would make sense to me.

I hadn't thought of it as editing a file since I always use it just to create the note, but of course you're right that in general that same window is also used for editing notes, so it wouldn't make sense for the back button to discard a pre-existing note you're editing.

@DivineDominion
Copy link
Contributor

DivineDominion commented Feb 15, 2018

I played with the app around some more. What I said holds true for Captures. When you edit item bodies in outlines, though, you can argue that you do have a form-like situation and want to be able to discard changes. I think that'd be reasonable, but the MobileOrg team may disagree :)

@mgmart mgmart added the bug Categorizes issue or PR as related to a bug. label Feb 18, 2018
@mgmart mgmart added this to the v1.7.5 milestone Feb 18, 2018
@mgmart
Copy link
Member

mgmart commented Feb 18, 2018

If an already existing capture is edited there should be an cancelling option.

@DivineDominion
Copy link
Contributor

I think Cancel & Done make sense when you are about to create a new "Capture". But for editing? There always is undo when you make mistakes while you type. (A dedicated undo button seems to be the new cool, by the way.) It's only an assumption: I think people rarely start editing an existing note and then want to cancel the whole process, rather preferring auto-saving of changes they make. (For what it's worth, a cancel button also is less consistent with existing iOS apps.)

@mgmart
Copy link
Member

mgmart commented Feb 20, 2018

From my point of view existing captures are item bodies residing in some kind of inbox.

Having the option to use an undo button seems fine for me. Using undo and then back would result in cancel, wouldn't it?

@DivineDominion
Copy link
Contributor

DivineDominion commented Feb 20, 2018 via email

@dive dive self-assigned this Oct 18, 2019
@dive
Copy link
Member

dive commented Oct 18, 2019

I think that this is a bad idea to straddling two worlds. MobileOrg as an application to handle notes and to work with notes, so, let's follow the rules for notes and in-place editing (Notes.app is a good example). In this case, it would be easier for users to work with it because the UX will be familiar. There are no reasons to mix different patterns.

I propose the following changes according to the discussion above and #193:

  • Remove the Done button from the capture screen and keep only the "+" button to create a new note quickly;
  • Do not save the note if it is empty;
  • Use system-wide UX solutions for the Undo (double-tap with three fingers, swipe left with three fingers to Undo, right for Redo on iOS 13 or "shake").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants