Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture mode improvements and fixes #251

Merged
merged 15 commits into from
Oct 21, 2019

Conversation

dive
Copy link
Member

@dive dive commented Oct 19, 2019

Hello there,

The list of changes in the pull request:

  • Notes List and New Note view controllers rewritten in Swift;
  • Empty notes are not saved by default;
  • Add (+) button replaced with the "New note" button;
  • Fixed an issue with the layout misalignment on the new note screen;
  • Removed redundant animation when you create a new note on top of the new note editor;
  • Default font switched to the system .body font;
  • Added insets around the text on the new note screen to improve UX;
  • Notes are sorted by the "changed at" date;
  • Notes on the list show relative timestamps (1 hour ago, tomorrow, etc) of the last edit.

These changes resolve #216 and #193. Everything else works as it was before.

There is a short video of how it works now.

Cheers,
Artem

@webframp
Copy link
Member

This looks nice, still trying it locally and will do a further review early tomorrow and probably merge

@dive
Copy link
Member Author

dive commented Oct 21, 2019

@webframp, thanks. Also, it would be nice to release a TestFlight build when this merged. Want to play with iCloud support via TestFlight distribution.

@webframp
Copy link
Member

webframp commented Oct 21, 2019

@dive totally agree. I’ll work on it. Still a manual process. In the past I looked at trying out the fastlane tools to automate submitting builds to testflight but never got it going. If that’s useful I might pick it back up.

@webframp webframp merged commit a2bd9cb into MobileOrg:develop Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture buttons' behaviors
2 participants