Apply latest suggested project settings #262
Conversation
As suggested by Xcode 11.4.1, using defaults
|
Just posting this before I go to sleep, so I remember to come back to it. FYI @dive only two warnings currently, both in https://github.com/MobileOrg/mobileorg/blob/develop/Classes/Utilities/UIAlertController%2BMobileOrg.swift#L47
Will try to find time this week to resolve. |
webframp
added
the
development process
There was a problem hiding this comment.
Thanks!
Yeah, it seems that we have to rewrite the mo_presentingViewController to avoid these "Cast always fails" warnings from the compiler. I suggest something like this:
private static var mo_presentingViewController: UIViewController? {
let rootViewController = UIApplication.shared.delegate?.window??.rootViewController
if let controller = (rootViewController as? UINavigationController)?.topViewController {
return controller
} else if let controller = (rootViewController as? UITabBarController)?.selectedViewController {
return controller
}
return rootViewController
}Since we already have these defined in `Global.shared.xcconfig` as discussed in #262 revert the automated changes applied by Xcode and bump the upgrade check value to bypass.
This is specifically to avoid recent "Cast always fails" compiler warnings. Tested a few minor different approaches to this refactor but just decided to go with what was suggested by @dive on #262 since it seems to work well for me in testing. #262 (review)
|
@dive updated based on feedback, thanks. I think this is good to go if you can take one last look. |
|
Tested this a bit more, seems fine and warnings are gone after last 2 commits here. Going to merge. |
As suggested by Xcode 11.4.1, using defaults