Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

chrome extension (development) id should always be static #156

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

fitzk
Copy link
Contributor

@fitzk fitzk commented Aug 22, 2024

added "public" key to manifest.json which is used to create the chrome extension id, now the id should not change
hpbepdaeenaphhfpikjnflmginblmipn

when we publish the app we will get a static id

I tested this locally and I got the same id each time

Summary by CodeRabbit

  • New Features

    • Added a cryptographic key to the application manifest, enhancing secure identification and authentication capabilities.
  • Impact

    • This change may improve interactions with other services requiring secure communication or verification.

Copy link

coderabbitai bot commented Aug 22, 2024

Walkthrough

Walkthrough

The update to the "Mocksi Lite: Next" application involves the addition of a new key-value pair in its JSON manifest file. This new field, labeled "key", contains a cryptographic key that enhances the application's functionality for secure identification or authentication purposes.

Changes

File Path Change Summary
.../mocksi-lite-next/manifest.json Added new field "key" containing a cryptographic key.

Sequence Diagram(s)

sequenceDiagram
    participant App as Mocksi Lite: Next
    participant Service as External Service
    App->>Service: Send request with key
    Service-->>App: Validate key and respond
Loading

Poem

Hop along the JSON trail,
A key appears, we cannot fail!
Securely tucked in bytes of night,
Our app now shines, oh what a sight!
With every hop, we leap and cheer,
For changes bold, the future's near! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fitzk fitzk requested a review from jonathankap August 22, 2024 23:49
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2b56761 and 7a4fd4a.

Files selected for processing (1)
  • apps/mocksi-lite-next/manifest.json (1 hunks)
Additional comments not posted (1)
apps/mocksi-lite-next/manifest.json (1)

27-27: Ensure secure management of the extension key.

The addition of the "key" field is crucial for maintaining a consistent Chrome extension ID. Ensure that this key is securely managed and not exposed in public repositories or logs to prevent unauthorized use.

Consider using environment variables or a secure vault for managing sensitive keys.

@fitzk fitzk changed the title chrome development id should always be hpbepdaeenaphhfpikjnflmginblmipn chrome extension (development) id should always be static Aug 22, 2024
@fitzk fitzk merged commit 91e8ced into main Aug 23, 2024
4 checks passed
@elg0nz elg0nz deleted the static-chrome-id branch September 12, 2024 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants