-
Notifications
You must be signed in to change notification settings - Fork 1
Allow users to specify the build environment when manually triggering the workflow. #171
Conversation
… the workflow. - Added a new input parameter 'environment' to the workflow_dispatch event in the GitHub Actions configuration. - The 'environment' input allows users to specify the build environment (choices: production, staging, or development) when manually triggering the workflow. - Removed the previous method where the EXTENSION_ENV variable was set based on the current branch name. - Updated the build step to use the user-defined 'environment' input instead of the previously utilized branch name for the EXTENSION_ENV variable. - This change improves the flexibility and clarity of environment configuration during the CI build process.
WalkthroughWalkthroughThe changes introduce a new input parameter for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Build Process
User->>GitHub Actions: Trigger workflow with environment input
GitHub Actions->>Build Process: Set EXTENSION_ENV to user input
Build Process->>GitHub Actions: Build extension
GitHub Actions-->>User: Return build result
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci.yml (2 hunks)
Additional comments not posted (3)
.github/workflows/ci.yml (3)
5-14
: LGTM!The new input parameter
environment
for theworkflow_dispatch
event is correctly implemented. It allows users to specify the build environment when manually triggering the workflow, with a default value of 'development' and a choice of options: 'production', 'staging', and 'development'.
56-56
: LGTM!The
EXTENSION_ENV
environment variable is correctly set to the value from the newly introducedinputs.environment
. This change streamlines the process of determining the build environment by allowing explicit user input.
62-62
: LGTM!The path for uploading the extension artifacts is correctly set to
./apps/mocksi-lite-next/dist
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by CodeRabbit
New Features
Improvements