-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added checks for inf & nan for state vars #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 30 +4
Lines 1522 1780 +258
==========================================
+ Hits 1522 1780 +258
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mirams
reviewed
Dec 15, 2022
Co-authored-by: Gary Mirams <[email protected]>
…ab/chaste-codegen into nan_inf_state_vars
I would probably replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds code to the C++ output th check for state variables becoming NON or INF.
As an example see chaste_codegen/data/tests/chaste_reference_models/Normal/non_dynamic_aslanidi_Purkinje_model_2009.cpp
The crucial bit is:
This section also still contains the previous checks where they are required.
Motivation and Context
Types of changes
Documentation checklist
Testing
I have re-run the Codegen test pack in with current develop branch of Chaste and thiscodegen branch. That test passes without issue.