Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lint rule for /inputpermission #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sweetniamhy
Copy link

Adding a lint rule for using the Player.inputPermissions API

@sweetniamhy sweetniamhy marked this pull request as draft March 25, 2024 23:08
@sweetniamhy sweetniamhy marked this pull request as ready for review May 1, 2024 00:15
@sweetniamhy
Copy link
Author

Just waiting for the stable docs to update with R21 out 😄

Copy link

@zaidraufskyboxlabs zaidraufskyboxlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@sweetniamhy
Copy link
Author

@rlandav @JakeShirley wondering about the beachball changefile check, is there anything I need to do? The link still won't work as it'll be in 1.14.0 stable, but wanted to get things ready

@sweetniamhy
Copy link
Author

@rlandav @JakeShirley wondering about the beachball changefile check, is there anything I need to do? The link still won't work as it'll be in 1.14.0 stable, but wanted to get things ready

nvm found it in the contributing doc 😄

@JakeShirley
Copy link
Contributor

@sweetniamhy Is this good to go?

@sweetniamhy
Copy link
Author

@sweetniamhy Is this good to go?

Oh, yes sorry I just need to run beachball on it I'll get that going 😄

@sweetniamhy
Copy link
Author

@JakeShirley when you have a chance to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants