Option to shut down managers if idle for too long #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennybp
changed the title
bennybp
force-pushed
the
manager_idle
branch
2 times, most recently
from
4bbe0df to
6e56f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(builds on PR #876)
Sometimes, we would like managers to shut down if they are not running any jobs for too long. This is particularly true if managers themselves are submitted as jobs to a queuing system.
This PR adds the functionality to specify a maximum idle time in the manager config:
max_idle_time. This time is approximate, as idleness is only checked at the time a manager fetches new tasks from the server.If at update time the idle time is beyond the configured max, the manager will stop itself.
Because of PR #876, this can also be specified as a string:
60sor30m, or with colons (30:00being 30 minutes).@j-wags
Status