Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add RPC methods to use in maintenance mode #382

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

TDemeco
Copy link
Contributor

@TDemeco TDemeco commented Feb 25, 2025

This PR adds the following RPC methods:

  • remove_file_from_file_storage: Allows a Provider to manually remove a file that it's currently storing in its file storage. Useful when an issue made it so a file that's no longer in its forest was incorrectly kept in its file storage.
  • add_files_to_forest_storage: Allows a Provider to manually add files to its forest storage.
    • It requires a forest key to know in which trie of the forest the files should be added, which means BSPs and MSPs can batch add multiple files in one call as long as they belong to the same forest key.
    • Useful when an issue made it so files that are currently in the file storage and should be part of a trie were incorrectly deleted from it or not added at all.
  • remove_files_from_forest_storage: Allows a Provider to manually remove files from a trie of its forest storage.
    • It requires a forest key to know from which trie of the forest the files should be removed, which means BSPs and MSPs can batch remove multiple files in one call as long as they belong to the same forest key.
    • Useful when an issue made it so files that the runtime thinks were deleted are still in the forest and as such there's an inconsistency between the local forest root and the on-chain recorded one.

Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@TDemeco TDemeco merged commit 270dad7 into main Feb 28, 2025
25 checks passed
@TDemeco TDemeco deleted the feat/add-maintenance-rpc-methods branch February 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants