C API 2.0 Tensor and TensorList #5799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
force-pushed
the
C_API2_data_objects
branch
from
04ef2a5 to
e27aa11
Compare
szkarpinski
reviewed
Feb 10, 2025
| // Interfaces | ||
| ////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| class ITensor : public _DALITensor, public RefCountedObject { |
There was a problem hiding this comment.
Do we use this ISomething convention in the code elsewhere?
Comment on lines
+352
to
+356
| tl_->Reset(); | ||
| tl_->SetSize(num_samples); | ||
| tl_->set_sample_dim(ndim); | ||
| tl_->SetLayout(new_layout); | ||
| tl_->set_type(dtype); |
There was a problem hiding this comment.
Why sometimes it's like_that and sometimes LikeThat?
| Validate(dtype); | ||
|
|
||
| for (int i = 0; i < num_samples; i++) { | ||
| if (ndim && !samples[i].shape) |
| @@ -0,0 +1,414 @@ | |||
| // Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Are you testing non-contiguous tensor lists here?
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
mzient
force-pushed
the
C_API2_data_objects
branch
from
e27aa11 to
361bf44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR adds wrappers for Tensor and TensorList that are later used to implement the C interface for those objects.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A