-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test file names #3881
Fix test file names #3881
Conversation
!test |
Review updated until commit addf428 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
add_test(test_nvfuser "${JIT_TEST_SRCS}" "") | ||
list(APPEND TEST_BINARIES test_nvfuser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today, this is implemented as an exception in our CI filtering rule. Let's fix it, instead of making this an exception. It is annoying that after I have typed test_
and pressed tab
for completion, only to remember that nvfuser tests are not starting from test_
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
!test |
There seems to be some CI scripting issue and I just fixed it. |
!test |
!test |
Our CI missed running
tutorial
because we have a filtering rule./bin/test_*
. Instead of adding another filtering rule, @xwang233 suggested that we should name all tests astest_*
, which I believe makes sense.