Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Communication scheduler, move meta-ops to ExprEval scheduler #3885

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Create Communication scheduler, move meta-ops to ExprEval scheduler #3885

wants to merge 8 commits into from
+143 −33

Conversation

nsarka
Copy link
Member

@nsarka nsarka commented Feb 13, 2025

Followup to Jingyue's comment from my HostIR lowering PR: #3835

This PR:

  1. Creates a SchedulerType Communication for segments that reshard.
  2. Moves segments that contains only meta ops (shape ops like reshape and transpose that will run on host via ExpressionEvaluator) to SchedulerType ExprEvaluator instead of NoOp.

@nsarka nsarka requested a review from wujingyue February 13, 2025 22:34
@nsarka nsarka self-assigned this Feb 13, 2025
@wujingyue wujingyue changed the title WIP: Create Communication scheduler, move meta-ops to ExprEval scheduler Create Communication scheduler, move meta-ops to ExprEval scheduler Feb 14, 2025
@wujingyue
Copy link
Collaborator

!test

wujingyue
wujingyue reviewed Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@wujingyue wujingyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is easier than I expected. Please make sure tests pass and then I'll approve.

csrc/scheduler/scheduler_types.h Show resolved Hide resolved
csrc/scheduler/communication.cpp Outdated Show resolved Hide resolved
@nsarka
Copy link
Member Author

nsarka commented Feb 18, 2025

!test

1 similar comment
@xwang233
Copy link
Collaborator

!test

@nsarka
Copy link
Member Author

nsarka commented Feb 18, 2025

!test

wujingyue
wujingyue approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@wujingyue wujingyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some CI failures caused by no-op => expr-eval. Make sure you fix them before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wujingyue wujingyue wujingyue approved these changes

Assignees

@nsarka nsarka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsarka @wujingyue @xwang233