Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abhi/llava next sp #12182

Draft
wants to merge 2 commits into
base: yash/llava_next_interleaved
Choose a base branch
from
Draft

Conversation

abhinavg4
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@abhinavg4 abhinavg4 changed the base branch from main to yash/llava_next_interleaved February 14, 2025 01:56
@abhinavg4 abhinavg4 marked this pull request as draft February 14, 2025 01:56
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.vlm.llava_next.data.sample
nemo/collections/vlm/llava_next/data/sample.py:2:0: W0611: Unused Dict imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:2:0: W0611: Unused Tuple imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:6:0: W0611: Unused VQASample imported from megatron.energon (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:6:0: W0611: Unused batch_list imported from megatron.energon (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:6:0: W0611: Unused batch_pad_stack imported from megatron.energon (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:7:0: W0611: Unused pad_sequence imported from torch.nn.utils.rnn (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:9:0: W0611: Unused MultiModalSampleConfig imported from nemo.collections.multimodal.data.energon.config (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:10:0: W0611: Unused SampleEncoder imported from nemo.collections.multimodal.data.energon.sample_encoder (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:10:0: W0611: Unused VQASampleEncoder imported from nemo.collections.multimodal.data.energon.sample_encoder (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:11:0: W0611: Unused MultiModalTaskEncoder imported from nemo.collections.multimodal.data.energon.task_encoder (unused-import)
nemo/collections/vlm/llava_next/data/sample.py:12:0: W0611: Unused logging imported from nemo.utils (unused-import)
************* Module nemo.collections.vlm.llava_next.data.task_encoder
nemo/collections/vlm/llava_next/data/task_encoder.py:179:0: C0301: Line too long (225/119) (line-too-long)
nemo/collections/vlm/llava_next/data/task_encoder.py:271:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/vlm/llava_next/data/task_encoder.py:1:0: W0611: Unused dataclass imported from dataclasses (unused-import)
nemo/collections/vlm/llava_next/data/task_encoder.py:1:0: W0611: Unused field imported from dataclasses (unused-import)
nemo/collections/vlm/llava_next/data/task_encoder.py:2:0: W0611: Unused Optional imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/task_encoder.py:9:0: W0611: Unused ImageTextRawBatch imported from nemo.collections.multimodal.data.energon.config (unused-import)
nemo/collections/vlm/llava_next/data/task_encoder.py:9:0: W0611: Unused ImageTextSample imported from nemo.collections.multimodal.data.energon.config (unused-import)
nemo/collections/vlm/llava_next/data/task_encoder.py:10:0: W0611: Unused VQASampleEncoder imported from nemo.collections.multimodal.data.energon.sample_encoder (unused-import)
************* Module nemo.collections.vlm.llava_next.data.vqa_sample_encoder
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:1:0: W0611: Unused dataclass imported from dataclasses (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:1:0: W0611: Unused field imported from dataclasses (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:2:0: W0611: Unused Dict imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:2:0: W0611: Unused List imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:2:0: W0611: Unused Optional imported from typing (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:5:0: W0611: Unused batch_list imported from megatron.energon (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:5:0: W0611: Unused batch_pad_stack imported from megatron.energon (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:6:0: W0611: Unused pad_sequence imported from torch.nn.utils.rnn (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:8:0: W0611: Unused ImageTextRawBatch imported from nemo.collections.multimodal.data.energon.config (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:8:0: W0611: Unused ImageTextSample imported from nemo.collections.multimodal.data.energon.config (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:9:0: W0611: Unused SampleEncoder imported from nemo.collections.multimodal.data.energon.sample_encoder (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:10:0: W0611: Unused MultiModalTaskEncoder imported from nemo.collections.multimodal.data.energon.task_encoder (unused-import)
nemo/collections/vlm/llava_next/data/vqa_sample_encoder.py:11:0: W0611: Unused LlavaNextTextRawBatch imported from nemo.collections.vlm.llava_next.data.sample (unused-import)
************* Module scripts.vlm.llava_next_pretrain
scripts/vlm/llava_next_pretrain.py:26:0: W0611: Unused import pdb (unused-import)

-----------------------------------
Your code has been rated at 9.48/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant