Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customization of a few parameters in scripts/vlm/llava_next_pretrain #12218

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bernardhan33
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Supports customization of num_workers, max_samples_per_sequence and shuffle_buffer_size in scripts/vlm/llava_next_pretrain.py.

Collection: vlm/core

Changelog

Supports customization of num_workers (defaults to 4), max_samples_per_sequence (defaults to 100) and shuffle_buffer_size (defaults to 100) in scripts/vlm/llava_next_pretrain.py.

Usage

torchrun --nproc_per_node=8 scripts/vlm/llava_next_pretrain.py \
  --devices=8 --tp=4 --data_type=energon --data_path='' \
  --num_workers=8 --max_samples_per_sequence=100 --shuffle_buffer_size=100 \
  --language_model_path=/root/.cache/nemo/models/lmsys/vicuna-7b-v1.5

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

…tomization to llava_next_pretrain

Signed-off-by: Bernard Han <[email protected]>
Signed-off-by: Bernard Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants