Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OpenAI Whisper Model #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MahmoudAshraf97
Copy link

This PR aims to enable exporting HF Whisper implementation to TRT-LLM checkpoint.
Although TRT already has a conversion script for both HF and original implementation, but implementing it here enables users to use modelopt for optimization and quantization techniques that aren't available yet in TRT-LLM

There are some sharp edges in this implementation, mostly because this is the second Enc-Dec model to be implemented after T5 so they are handled as edge cases, perhaps having a generalized Enc-Dec path can be better, also there might be some code duplication between whisper and T5 in TRT-LLM config creation that can be unified

@yuekaizhang
Copy link

@MahmoudAshraf97 Hi, thanks for your effort. I would take this PR into our internal gitlab (We don't have CI running in Github). Also, we would add your name into the co-author list and credit your work on the release notes for whisper fp8 quant support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants