Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Enable quantized activation backward kernels in operation-based API tests #1463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timmoon10
Copy link
Collaborator

@timmoon10 timmoon10 commented Feb 7, 2025

Description

#1462 and #1460 are attempting to fix a correctness bug in the FP8 and MXFP8 backward activation kernels. This PR modifies the operation-based API tests (test_fusible_ops.py) so that they includes these kernels. These tests have tighter tolerances than the module tests (e.g. test_numerics.py), so they would have caught this bug.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring
  • Testing

Changes

  • Enable quantized activation backward kernels in operation-based API tests

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added the testing Improvements to tests or testing infrastructure label Feb 7, 2025
@timmoon10 timmoon10 changed the base branch from release_v2.0 to main February 7, 2025 22:21
@timmoon10 timmoon10 changed the base branch from main to release_v2.0 February 7, 2025 22:22
@timmoon10 timmoon10 force-pushed the te-sequential-quantized-activation-backward branch from cb9701c to 1470ed8 Compare February 7, 2025 22:51
@timmoon10 timmoon10 changed the base branch from release_v2.0 to main February 7, 2025 22:51
@timmoon10 timmoon10 force-pushed the te-sequential-quantized-activation-backward branch from 1470ed8 to 2d936dc Compare February 7, 2025 23:14
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant