ishard: maintenance #207
Merged
ishard: maintenance #207
+228
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nahemah1022
commented
Jan 14, 2025
Nahemah1022
commented
$ cd cmd/ishard/
$ make lint
Running lint cmd/ishard...
ishard/config/sample.go:30:1: File is not properly formatted (gci)
ErrorPrefix = "[Error]"
^
ishard/ishard_test.go:33: fileSize int64, sampleKeyPattern config.SampleKeyPattern, randomize, dropout bool) { //nolint:unparam // dropout to be implemented
|
alex-aizman
reviewed
Jan 15, 2025
| @@ -129,6 +129,11 @@ cli-autocompletions: ## Add CLI autocompletions | |||
| @echo "Adding CLI autocomplete..." | |||
There was a problem hiding this comment.
I've fixed all lint errors and added the ishard lint check to the main Makefile. also added ishard installing guide to the README in /cmd directory. should be ready to merge.
Nahemah1022
force-pushed
the
main
branch
2 times, most recently
from
4886998 to
a1eb921
Compare
* add make for the binary executable and lint * refactor CLI config parsing * extend test cases * update docs Signed-off-by: Alex Aizman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.