-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace _CCCL_IF_CONSTEXPR
#3775
base: main
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
🟩 CI finished in 1h 43m: Pass: 100%/155 | Total: 2d 17h | Avg: 25m 22s | Max: 1h 23m | Hits: 70%/239257
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
+/- | Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 155)
# | Runner |
---|---|
108 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
12 | linux-amd64-gpu-rtx2080-latest-1 |
10 | linux-arm64-cpu16 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
| ``_CCCL_CONSTEXPR_CXX14`` | Enable ``constexpr`` for C++14 or newer | | ||
+-----------------------------+----------------------------------------------------------+ | ||
| ``_CCCL_CONSTEXPR_CXX17`` | Enable ``constexpr`` for C++17 or newer | | ||
+-----------------------------+----------------------------------------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: those are not removed with the PR but meh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, since you have to rebase anyway, please readd those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue for removing those: #3780
Fixes #3766
Description
Replace _CCCL_IF_CONSTEXPR with
if constexpr