-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlisted distributions #62
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates appear to increase the scope of support and that's counter to my instincts--but you must have your reasons. PLMK what I can clarify and thank you.
@@ -16,7 +16,12 @@ backlinks: none | |||
|
|||
## Linux Distributions | |||
|
|||
Supported Linux distributions are listed below: | |||
The NVIDIA Container Toolkit has been qualified against the following platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect your choice of "qualified" rather than supported is to communicate some subtlety. If feels dicey to me, but it's you who answers questions and not me.
nit: s/has been/is/, unless there is a consideration that I'm overlooking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that people reach out to us all the time pointing out that we need to add "Debian 12" support or "Ubuntu 24.04" support, where we are reasonably confident that the packages should work as is. The caveat is that we have not officiallty tested against these configurations. If you have a suggestion on how to better call this out, that would be appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example: NVIDIA/nvidia-container-toolkit#482 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great and important discussion. I wonder: what do we really do?
I see a contradiction between
we have not officially tested against these configurations
and
has been qualified
I see "qualification testing" as one of the later stages of testing in a release process, in particular meaning: I take a release candidate and make sure it works against all supported platforms.
edit: oh, I see. The table shows what in fact hast been properly qualification-tested.
You want to imply that we may support (in a loose understanding of the word) more than what is shown in the table.
Makes sense. Yeah we can try to put this into really simple words. Towards the community, it's typically important and sufficient to express the intent in a friendly tone. That removes much attack surface / source of frustration.
I will work on a proposal!
Note that the installation packages are generally forward-compatible and the | ||
omission of newer distributions from this list below does not indicate that the | ||
NVIDIA Container Toolkit cannot be used there. Specific issues with newer | ||
distributions should be reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be rephrased more concisely.
NVIDIA Container Toolkit is generally forward compatible and works successfully on newer versions of the operating systems in the following table.
I've puzzled through the thought of directing readers to report issues from this section of the text, and I can't think why it's more compelling to urge that action here than in any other section. If you prefer to keep it, consider something like "Open an issue in the toolkit repository to report problems."
picking up the discussion from NVIDIA#62
No description provided.