Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of support for C++ operators #2511

Open
wants to merge 337 commits into
base: experimental/operators
Choose a base branch
from
Open

First pass of support for C++ operators #2511

wants to merge 337 commits into from
+27,346 −4,150

Conversation

anthony-santana
Copy link
Collaborator

Description

This is an initial commit to the experimental branch containing a first pass of work towards operator support in C++

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

sacpis
sacpis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests are running successfully.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2b42628 to 8150d70 Compare January 16, 2025 22:10
@sacpis sacpis force-pushed the dynamics_cpp_operators branch 4 times, most recently from bbec3ed to 5b14fad Compare January 28, 2025 00:12
@sacpis sacpis force-pushed the dynamics_cpp_operators branch 5 times, most recently from 3e3909f to 8c91e88 Compare February 4, 2025 21:49
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from e0d90b6 to 3f90dea Compare February 6, 2025 21:19
@bettinaheim @sacpis
wip to use elementary_operator as matrix handler
3511e7c 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
kinded of more cleaned up but left-hand arithmethics need more thought
68c07c8 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
constrain the templates
45f6926 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
making the left hand arithmetics friends
d663b02 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
cleaned up assignments
3dc2d50 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
fixing a some types
3d52d47 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
this builds, but needs to be cleaned up
6c04650 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
scalar ops tests
0cb84a8 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
to be deleted again - just some notes
a5399d3 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
more memory experiments
a637313 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
revised the data structures - all tests now pass again
0aa6e85 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
store one coefficient per product only
8cb682e 
Signed-off-by: Bettina Heim <[email protected]>
bettinaheim and others added 18 commits February 13, 2025 15:34
@bettinaheim @sacpis
undoing accidentally committed change
b422030 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
product optimizations
e411cb7 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
first version with perf improvements
de49502 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
perf version 2 with map
a70b22c 
Signed-off-by: Bettina Heim <[email protected]>
@1tnguyen
Fix linblad test and fix leak
fcdb4c8 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis
Merge branch 'dynamics_cpp_operators' of https://github.com/sacpis/cu…
44341e0 
…da-quantum into dynamics_cpp_operators
@1tnguyen
Add full density matrix evolve and reduce test time
5d6e73e 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis
Merge branch 'dynamics_cpp_operators' of https://github.com/sacpis/cu…
6769eb6 
…da-quantum into dynamics_cpp_operators
@1tnguyen
Support static collapse op and add a test
0d31c8b 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis
Merge branch 'dynamics_cpp_operators' of https://github.com/sacpis/cu…
2178b0e 
…da-quantum into dynamics_cpp_operators
@sacpis
* Adding conversion mechanism (to operator_sum<product_operator>) after
eb5688b 
  merging in Bettina's commits
* Fixing build errors by including only operators.h in operator_sum and
  product_operator unittests
* Removing helpers.h in runtime/cudaq, as it has been added in
  runtime/cudaq/dynamics
* Removing duplicate template instantiations of product_operator
* Formatting

Signed-off-by: Sachin Pisal <[email protected]>
@bettinaheim @sacpis
changes to the test script
f2ba966 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
checking in v2 perf numbers for comparison
b5ada26 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
Bringing in more commits from Bettina's branch
79a9b15 
Signed-off-by: Sachin Pisal <[email protected]>
@1tnguyen
Hook public API
ae4ae7c 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Port cudm_state under cudaq::SimulationState type
4bd04be 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
More cleanup: only use cudaq::state at the API surface
69118b5 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
More cleanup: remove the type alias
9fdf186 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis sacpis self-requested a review February 17, 2025 04:16
1tnguyen and others added 11 commits February 17, 2025 05:52
@1tnguyen
Add handle to sim class
6f03515 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
Some fixes for _wrap_callback and add TODO
d1ddf76 
Signed-off-by: Thien Nguyen <[email protected]>
@bettinaheim @sacpis
commit before switching branches
737c667 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
third and final version with a decent performance across the board
b682430 
Signed-off-by: Bettina Heim <[email protected]>
@bettinaheim @sacpis
adding missing rvalue overloads
a3ad658 
Signed-off-by: Bettina Heim <[email protected]>
@sacpis
Fixing Scalar callback using Python callback from cudensitymat and fo…
8ee54f2 
…rmatting

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Removing mutex
aa8d3f0 
Signed-off-by: Sachin Pisal <[email protected]>
@1tnguyen
Passing param names to scalar callback
272f436 
Signed-off-by: Thien Nguyen <[email protected]>
@1tnguyen
integrator + schedule in the loop to resolve parameter values
0521183 
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis
Adding tensor callback with the unittest
1a652bf 
Signed-off-by: Sachin Pisal <[email protected]>
@1tnguyen
Support state vec -> density matrix conversion if collapse ops are pr…
0784b45 
…esent

Signed-off-by: Thien Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi schweitzpgi is a code owner

@sacpis sacpis Awaiting requested review from sacpis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anthony-santana @sacpis @bettinaheim @1tnguyen @schweitzpgi @yitchen-tim @cuda-quantum-bot