Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2620 - fixes a bug with the new QIR codegen. #2621

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

schweitzpgi
Copy link
Collaborator

This fixes an issue where after lowering to a CFG the code may still have several basic blocks and feed quantum references via block arguments.

Description

This fixes an issue where after lowering to a CFG the code may still
have several basic blocks and feed quantum references via block arguments.

Signed-off-by: Eric Schweitz <[email protected]>
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
Copy link

@iqbalbhatti49 iqbalbhatti49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QIR integration is clear, and MLIR transformations work as expected!

@schweitzpgi schweitzpgi enabled auto-merge (squash) February 14, 2025 22:38
@schweitzpgi schweitzpgi added the bug fix To be listed under Bug Fixes in the release notes label Feb 14, 2025
Copy link
Collaborator

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2025
@schweitzpgi schweitzpgi merged commit 009177e into NVIDIA:main Feb 15, 2025
216 of 217 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 15, 2025
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2025
@schweitzpgi schweitzpgi deleted the ch-codegen.fix branch February 15, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants