Add configuration options for changing embedding model name and NIM endpoint url at runtime #440
+164
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJar
requested review from
jperez999,
jdye64,
edknv and
drobison00
and removed request for
a team,
jperez999,
jdye64,
edknv and
drobison00
|
Looks good; sorry, the recent unification updates introduced some differences that break some of these issues. Happy to sync on it and help merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds model name, and NIM endpoint url configuration options to the embed task so that users can configure different embedding NIMs/models at runtime. If these configuration options aren't set it falls back to the current behavior of pulling the model name from an env variable when starting the container.
Checklist