Fix small image filtering in chart extraction stage #446
+18
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the logic for filtering out small images in the chart extraction stage. When we filter out small images, we keep track of the indices in the original image batch in
valid_indices
and usevalid_indices
later to restore the original order in the results. The table extraction has similar logic:nv-ingest/src/nv_ingest/stages/nim/table_extraction.py
Lines 61 to 66 in f4a3819
nv-ingest/src/nv_ingest/stages/nim/table_extraction.py
Lines 85 to 88 in f4a3819
which we also follow in this PR.
Checklist