Migrate from NVIDIA/go-nvlib to NVIDIA/go-nvml and link against nvidia-ml library #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
since the release 0.3.0 of NVIDIA/go-nvlib package, the nvml has been moved to NVIDIA/go-nvml.
Without migration, nvkind was screaming about missing symbol:
Other problem was with symbol resolving, for some reason, nvkind binary did not had a dynamic dependency on
libnvidia-ml.so
:Decided to add an additional
ldflags
to explicitly link against the missing dependency, resulting in:Let me know if you are fine with this change.
Best regards,
TheAifam5