Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on AIX & Solaris #295

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix compilation on AIX & Solaris #295

wants to merge 6 commits into from

Conversation

dougnazar
Copy link
Contributor

@dougnazar dougnazar commented Feb 19, 2025 •
edited
Loading

Fixes:

  • Detect if linker supports rpath option.
  • Only use rpath if it is required (missing library or version mismatch).
  • Add Makefile recipe for snprintf.o as AIX libc doesn't have asprintf.
  • Prioritize local headers over additional system includes.
  • Prioritize include directories without prefix.
  • Check if default system paths are enough for compile.

Cleanups:

  • AIX uses the const version of the structures.
  • Notate the intentional fallthoughs in the sprintf code.
  • Modernize autoconf

Fixes: #293
Fixes: #294

@dougnazar
Fix compilation on AIX
9b034b4 
Detect if linker supports rpath option.
Only use rpath if it is required (missing library or version mismatch).
Add Makefile recipe for snprintf.o as AIX libc doesn't have asprintf.
@dougnazar
Minor warning cleanups.
af021c8 
AIX uses the const version of the structures.
Notate the intentional fallthoughs in the sprintf code.
@dougnazar
Prioritize local headers over additional system includes.
ccc33fa
@dougnazar
Prioritize include directories without prefix.
d827b1a 
It is preferred to find an include path that uses a prefix instead of
a path that include the prefix.

-I/usr/include && #include <openssl/ssl.h>
vs
-I/usr/include/openssl && #include <ssl.h>
@dougnazar
Add check if default system paths are enough for compile.
280319e
@dougnazar
Modernize autoconf
dbf2f89 
Update using autoupdate.
Regenerate using autoconf 2.72.
@dougnazar dougnazar mentioned this pull request Feb 27, 2025
Open
@dougnazar dougnazar changed the title Fix compilation on AIX Fix compilation on AIX & Solaris Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nrpe-4.1.3 make failure on Solaris 11 get_dh2048 undefined Compilation failure NRPE 4.1.3 on AIX 7.2
1 participant
@dougnazar