Add jthread implementation for Clang #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this, I agree with waiting for Clang 16. If the gcc build doesn't need jthread, I think we should leave this PR for now and merge it as we make the switch. Sound good? |
|
I agree, I'll leave this open as-is for now. |
NeRdTheNed
force-pushed
the
jthread-clang-polyfill
branch
from
2295f5d to
3607e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang does not yet implement jthread, causing builds with Clang to fail. This PR adds an implementation of jthread from https://github.com/StirlingLabs/jthread, which acts as a polyfill when building with a version of Clang which does not support jthread (currently all versions of Clang). This will allow future versions of Clang to build AmalgamEngine.
It's noted in Clang 16's future release notes that it will support parenthesised aggregate initialisation, the only other missing feature in Clang 15 required to build AmalgamEngine. After manually replacing all uses of parenthesised aggregate initialisation, AmalgamEngine is able to build with Clang 15, but the changes are somewhat intrusive and brittle, so it might just be best to wait for Clang 16 to release. Clang 16 seems to be at the release candidate stage, so it's likely to get a full release soon.