Changed AsyncAPIConsumer.get_action_name #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishnash
reviewed
Jan 21, 2025
| @@ -236,8 +236,8 @@ async def get_action_name( | |||
|
|
|||
| Override this method if you do not want to use `{"action": "action_name"}` as the way to describe actions. | |||
| """ | |||
| action = content.pop("action") | |||
There was a problem hiding this comment.
Since a consumer instances might be handling multiple actions at once if actions by using @action(detached: true) setting this as an instance property is not a good idea.
You could look into using the contextvars module for this then the value would be scoped to the async task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed this method so that action is attribute of class object by self.action