Fix rendering of metrics with special characters #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knedlsepp
force-pushed
the
fix-metrics-rendering-with-special-characters
branch
from
f7b6fed to
3c9564a
Compare
My main motivation here is to get metrics with brackets to work in order to support "pytest" test names: - test_foo.py::test_bar[1] - test_foo.py::test_bar[2] I couldn't find an "HTML escape"-style function that would generate valid html `id` attribute names from random strings, so I went with a hash digest instead.
knedlsepp
force-pushed
the
fix-metrics-rendering-with-special-characters
branch
from
3c9564a to
d22d030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main motivation here is to get metrics with brackets to work in order
to support "pytest" test names:
test_foo.py::test_bar[1]test_foo.py::test_bar[2]I couldn't find an "HTML escape"-style function that would generate
valid html
idattribute names from arbitrary strings, so I went with ahash digest instead.
(See also the previous fix for metrics with dots)