yesplaymusic: drop #364839
Merged
yesplaymusic: drop #364839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like YesPlayMusic has been effectively abandoned upstream with numerous usability and API bugs preventing it from working, while using old, unsupported Node versions (14 and 16) and Electron versions (22). While there have been forks and projects created in its image (see qier222/YesPlayMusic#2344), it would be better if we drop YesPlayMusic first, and package any fork that manages to garner enough momentum. Part of NixOS#296939
23 tasks
github-actions
bot
added
10.rebuild-darwin: 0
|
Cc @LostAttractor as maintainer |
I’m not using this for a long time. Due to the large number of API changes, it is inevitable that the project will be deprecated. |
LostAttractor
approved these changes
Dec 16, 2024
wegank
added
the
12.approvals: 1
getchoo
reviewed
Dec 17, 2024
getchoo
approved these changes
Dec 17, 2024
getchoo
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like YesPlayMusic has been effectively abandoned upstream with numerous usability and API bugs preventing it from working, while using old, unsupported Node versions (14 and 16) and Electron versions (22).
While there have been forks and projects created in its image (see qier222/YesPlayMusic#2344), it would be better if we drop YesPlayMusic first, and package any fork that manages to garner enough momentum.
Part of #296939
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.