Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashrom: 1.3 -> 1.5.1 #382143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

flashrom: 1.3 -> 1.5.1 #382143

wants to merge 1 commit into from

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Feb 14, 2025

Things done

This seems to break the darwin build, but I'm not sure how to fix it.
Input from a darwin expert would be appreciated.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r-vdp r-vdp requested a review from jiegec February 14, 2025 21:37
@r-vdp
Copy link
Contributor Author

r-vdp commented Feb 14, 2025

@jiegec I see that you fixed the darwin build in the past. This version bumps breaks it again and I don't really know how to fix it.
Maybe you could take a look if you still care about this package.

@fpletz fpletz changed the title flashrom: 1.3 -> 1.5 flashrom: 1.3 -> 1.5.1 Feb 15, 2025
@r-vdp r-vdp requested a review from a team February 15, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant