feluda: init at 1.3.0 #382154
Open
feluda: init at 1.3.0 #382154
+2,543
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
ofborg
bot
added
the
2.status: merge conflict
transgirllucy
force-pushed
the
master
branch
from
035410e to
ee082f0
Compare
ofborg
bot
removed
the
2.status: merge conflict
ethancedwards8
suggested changes
Feb 14, 2025
pkgs/by-name/fe/feluda/package.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "anistark"; | ||
| repo = pname; | ||
| rev = "98fd4a640cec620dee85c595ec1376949bb025e5"; |
There was a problem hiding this comment.
please use the version tag. https://github.com/anistark/feluda/releases/tag/1.3.0. the version should be 1.3.0 as well. Also, please do not use pname recursively. Also, please use hash with the hash prefix instead of sha256. Example:
Suggested change
| rev = "98fd4a640cec620dee85c595ec1376949bb025e5"; | |
| repo = "feluda"; | |
| tag = version; | |
| hash = "sha256-..."; |
transgirllucy
force-pushed
the
master
branch
from
ee082f0 to
a90170b
Compare
ethancedwards8
suggested changes
Feb 14, 2025
ethancedwards8
suggested changes
Feb 14, 2025
transgirllucy
force-pushed
the
master
branch
from
a90170b to
c9a5149
Compare
|
@transgirllucy why did you mark this thread as resolved? #382154 (comment) . Using your own lock files is discouraged as they are hard to review and consume significant disk space/increase eval times. Please consider using the upstream repo's lock file or add a comment noting why the upstream one will not work if that is the case. |
|
Also, please make it a practice of building your packages locally before pushing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.